Fixed the 18751 and 18896 flaky tests by Ahamed-Ali · Pull Request #33737 · dotnet/maui

Ahamed-Ali · 2026-01-28T12:00:18Z

Description of Change

This pull request updates test data and test code for two monkey-related UI test cases, focusing on removing dependencies on external internet resources and cleaning up test attributes and structure. The main changes include switching image sources from URLs to local files, removing internet connectivity checks, and simplifying test code and attributes.

Test Data Updates:

Updated all ImageUrl fields in the MonkeysViewModel (used by both issues) to reference local image files instead of external URLs, eliminating the need for internet access during tests.

Test Code Cleanup and Simplification:

Removed internet connectivity checks and related test delays from Issue18751Test and Issue18896Test, since images are now loaded locally. [1] [2]
Simplified screenshot verification in Issue18896Test by removing the retry delay parameter.

UI Test Enhancement:

Enabled HasUnevenRows in the ListView for Issue18896 to better support variable item heights.

Issues Fixed

Fixes #33507

sheiksyedm · 2026-01-28T12:28:36Z

/azp run maui-pr-uitests

azure-pipelines · 2026-01-28T12:28:48Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This pull request aims to reduce flakiness in Issue18751/Issue18896 UI tests by removing reliance on external network-hosted images and simplifying the tests now that data is local.

Changes:

Switched monkey image sources from external URLs to local image files in HostApp test data.
Simplified the Issue18751/Issue18896 UI tests by removing internet connectivity checks and related attributes.
Updated Issue18896 UI (ListView) configuration to better support variable row heights.

Reviewed changes

Copilot reviewed 5 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18896.cs	Removes connectivity checks/skip attributes; keeps a fixed sleep before screenshot (flakiness concern).
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18751.cs	Removes connectivity checks and async delay; simplifies test to screenshot after page load.
src/Controls/tests/TestCases.HostApp/Issues/Issue18896.xaml.cs	Drops `isInternetRequired: true` from the Issue attribute.
src/Controls/tests/TestCases.HostApp/Issues/Issue18896.xaml	Adds `HasUnevenRows="True"` and minor formatting updates.
src/Controls/tests/TestCases.HostApp/Issues/Issue18751.xaml.cs	Updates `MonkeysViewModel` image references to local files (but Issue attribute still says internet required).
src/Controls/tests/TestCases.HostApp/Resources/Images/papio.jpg	Adds local image asset used by test data.
src/Controls/tests/TestCases.HostApp/Resources/Images/capuchin.jpg	Adds local image asset used by test data.
src/Controls/tests/TestCases.HostApp/Resources/Images/saimiri.jpg	Adds local image asset used by test data.
src/Controls/tests/TestCases.HostApp/Resources/Images/golden.jpg	Adds local image asset used by test data.
src/Controls/tests/TestCases.HostApp/Resources/Images/alouatta.jpg	Adds local image asset used by test data.

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18896.cs

src/Controls/tests/TestCases.HostApp/Issues/Issue18751.xaml.cs

kubaflo

When you fix the copilot suggestions it will be ready to go

rmarinho · 2026-01-28T22:09:26Z

/azp run

azure-pipelines · 2026-01-28T22:09:49Z

Azure Pipelines successfully started running 3 pipeline(s).

- Issue18751/18896 local images: covered by #33737 - Issue12134 timeout: covered by #33689 (uses native CookieManager)

sheiksyedm · 2026-01-29T06:34:34Z

/azp run maui-pr-uitests

azure-pipelines · 2026-01-29T06:34:44Z

Azure Pipelines successfully started running 1 pipeline(s).

sheiksyedm · 2026-01-29T09:44:12Z

/azp run maui-pr-uitests

azure-pipelines · 2026-01-29T09:44:23Z

Azure Pipelines successfully started running 1 pipeline(s).

sheiksyedm · 2026-01-29T14:37:38Z

One mac base image still needs to be added here. All Mac tests are failing due to the Xcode selection issue.

jfversluis · 2026-01-29T15:53:17Z

/rebase

azure-pipelines · 2026-01-29T16:02:17Z

Azure Pipelines successfully started running 1 pipeline(s).

- Issue18751/18896 local images: covered by #33737 - Issue12134 timeout: covered by #33689 (uses native CookieManager)

sheiksyedm · 2026-01-30T06:56:08Z

/azp run maui-pr-uitests

azure-pipelines · 2026-01-30T06:56:19Z

Azure Pipelines successfully started running 1 pipeline(s).

…33749) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Description This PR improves the reliability of several flaky UI tests by: 1. **Replacing `Thread.Sleep` with `retryTimeout`** - The `retryTimeout` parameter keeps retrying screenshot comparisons until they match or timeout, adapting to actual UI timing across different machines/load conditions. 2. **Fixing Issue10563 SwipeView button animations** - Added flat `Background = SolidColorBrush(Colors.LightGray)` to buttons to prevent ripple animation artifacts that caused visual differences on CI. ## Changes | Test | Issue | Fix | |------|-------|-----| | Issue10563 | Button ripple animation artifacts in SwipeView test | Flat button background + updated baselines | | Issue18857 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(2)` | | Issue24856 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(2)` | | Issue25192 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(2)` | | Issue27418 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(2)` | | Issue28657 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(2)` | | Issue30575 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(3)` | ## Related PRs (not overlapping) - #33737 - Fixes Issue18751/18896 (local monkey images) - #33689 - Fixes Issue12134 (WebView cookies) --------- Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com>

…otnet#33749) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Description This PR improves the reliability of several flaky UI tests by: 1. **Replacing `Thread.Sleep` with `retryTimeout`** - The `retryTimeout` parameter keeps retrying screenshot comparisons until they match or timeout, adapting to actual UI timing across different machines/load conditions. 2. **Fixing Issue10563 SwipeView button animations** - Added flat `Background = SolidColorBrush(Colors.LightGray)` to buttons to prevent ripple animation artifacts that caused visual differences on CI. ## Changes | Test | Issue | Fix | |------|-------|-----| | Issue10563 | Button ripple animation artifacts in SwipeView test | Flat button background + updated baselines | | Issue18857 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(2)` | | Issue24856 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(2)` | | Issue25192 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(2)` | | Issue27418 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(2)` | | Issue28657 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(2)` | | Issue30575 | Thread.Sleep causes flakiness | `retryTimeout: TimeSpan.FromSeconds(3)` | ## Related PRs (not overlapping) - dotnet#33737 - Fixes Issue18751/18896 (local monkey images) - dotnet#33689 - Fixes Issue12134 (WebView cookies) --------- Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com>

PureWeen · 2026-02-02T21:02:43Z

the tests these are involved with are all passing

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 28, 2026

Ahamed-Ali added the testing-flakiness label Jan 28, 2026

sheiksyedm added the area-testing Unit tests, device tests label Jan 28, 2026

sheiksyedm marked this pull request as ready for review January 28, 2026 12:28

Copilot AI review requested due to automatic review settings January 28, 2026 12:28

Copilot started reviewing on behalf of sheiksyedm January 28, 2026 12:28 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18896.cs Outdated Show resolved Hide resolved

src/Controls/tests/TestCases.HostApp/Issues/Issue18751.xaml.cs Show resolved Hide resolved

Ahamed-Ali added the community ✨ Community Contribution label Jan 28, 2026

kubaflo requested changes Jan 28, 2026

View reviewed changes

PureWeen mentioned this pull request Jan 28, 2026

[Testing] Fix flaky UI tests: retryTimeout and SwipeView button fix #33749

Merged

github-actions bot force-pushed the ImageTestFailure branch from 792992a to a284f8d Compare January 28, 2026 22:13

PureWeen added a commit that referenced this pull request Jan 29, 2026

Remove changes covered by other PRs (#33737, #33689)

c5d25d5

- Issue18751/18896 local images: covered by #33737 - Issue12134 timeout: covered by #33689 (uses native CookieManager)

PureWeen added a commit that referenced this pull request Jan 29, 2026

Remove changes covered by other PRs (#33737, #33689)

8de0481

- Issue18751/18896 local images: covered by #33737 - Issue12134 timeout: covered by #33689 (uses native CookieManager)

build-analysis bot mentioned this pull request Jan 29, 2026

Project build failure causing test run abort in RunOniOS_BlazorRelease on mac_runios_blazor_release job #33744

Closed

kubaflo previously approved these changes Jan 29, 2026

View reviewed changes

Ahamed-Ali added 4 commits January 29, 2026 15:54

Fixed the 18751 and 18896 flaky tests

59aace3

Updated the images and review concerns

78775c2

updated to hide scrollbar in windows and mac

3262474

Resave the correct image of listview after scrollup

7b5c152

github-actions bot force-pushed the ImageTestFailure branch from 872ab90 to 7b5c152 Compare January 29, 2026 15:54

github-actions bot pushed a commit that referenced this pull request Jan 29, 2026

Remove changes covered by other PRs (#33737, #33689)

b6349bb

- Issue18751/18896 local images: covered by #33737 - Issue12134 timeout: covered by #33689 (uses native CookieManager)

Updated the images

6f19518

Ahamed-Ali dismissed kubaflo’s stale review via 6f19518 January 30, 2026 04:41

PureWeen approved these changes Feb 2, 2026

View reviewed changes

PureWeen merged commit 9b2ae2b into dotnet:main Feb 2, 2026
142 of 149 checks passed

Comments

Conversation

Ahamed-Ali commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Uh oh!

sheiksyedm commented Jan 28, 2026

Uh oh!

azure-pipelines bot commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

kubaflo left a comment

Choose a reason for hiding this comment

Uh oh!

rmarinho commented Jan 28, 2026

Uh oh!

azure-pipelines bot commented Jan 28, 2026

Uh oh!

sheiksyedm commented Jan 29, 2026

Uh oh!

azure-pipelines bot commented Jan 29, 2026

Uh oh!

sheiksyedm commented Jan 29, 2026 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Jan 29, 2026

Uh oh!

sheiksyedm commented Jan 29, 2026

Uh oh!

jfversluis commented Jan 29, 2026

Uh oh!

azure-pipelines bot commented Jan 29, 2026

Uh oh!

sheiksyedm commented Jan 30, 2026

Uh oh!

azure-pipelines bot commented Jan 30, 2026

Uh oh!

PureWeen commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Ahamed-Ali commented Jan 28, 2026 •

edited

Loading

sheiksyedm commented Jan 29, 2026 •

edited by jfversluis

Loading